Checkstyle Results

The following document contains the results of Checkstyle.

Summary

Files	Infos	Warnings	Errors
68	0	64	0

Files

Files	I	W	E
edu/internet2/middleware/shibboleth/idp/Version.java	0	1	0
edu/internet2/middleware/shibboleth/idp/authn/AuthenticationEngine.java	0	5	0
edu/internet2/middleware/shibboleth/idp/authn/Saml2LoginContext.java	0	1	0
edu/internet2/middleware/shibboleth/idp/authn/provider/IPAddressLoginHandler.java	0	3	0
edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginHandler.java	0	1	0
edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginServlet.java	0	1	0
edu/internet2/middleware/shibboleth/idp/config/profile/ProfileHandlerNamespaceHandler.java	0	4	0
edu/internet2/middleware/shibboleth/idp/config/profile/SAMLMetadataHandlerBeanDefinitionParser.java	0	2	0
edu/internet2/middleware/shibboleth/idp/config/profile/StatusHandlerBeanDefinitionParser.java	0	1	0
edu/internet2/middleware/shibboleth/idp/config/profile/authn/PreviousSessionLoginHandlerBeanDefinitionParser.java	0	1	0
edu/internet2/middleware/shibboleth/idp/profile/AbstractSAMLProfileHandler.java	0	2	0
edu/internet2/middleware/shibboleth/idp/profile/IdPProfileHandlerManager.java	0	2	0
edu/internet2/middleware/shibboleth/idp/profile/SAMLMetadataProfileHandler.java	0	2	0
edu/internet2/middleware/shibboleth/idp/profile/saml1/AbstractSAML1ProfileHandler.java	0	4	0
edu/internet2/middleware/shibboleth/idp/profile/saml1/ArtifactResolution.java	0	1	0
edu/internet2/middleware/shibboleth/idp/profile/saml1/AttributeQueryProfileHandler.java	0	1	0
edu/internet2/middleware/shibboleth/idp/profile/saml1/BaseSAML1ProfileRequestContext.java	0	1	0
edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSODecoder.java	0	1	0
edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSOProfileHandler.java	0	2	0
edu/internet2/middleware/shibboleth/idp/profile/saml2/AbstractSAML2ProfileHandler.java	0	13	0
edu/internet2/middleware/shibboleth/idp/profile/saml2/ArtifactResolution.java	0	2	0
edu/internet2/middleware/shibboleth/idp/profile/saml2/AttributeQueryProfileHandler.java	0	2	0
edu/internet2/middleware/shibboleth/idp/profile/saml2/BaseSAML2ProfileRequestContext.java	0	1	0
edu/internet2/middleware/shibboleth/idp/profile/saml2/SSOProfileHandler.java	0	10	0

Rules

Rules	Violations	Severity
JavadocMethod allowThrowsTagsForSubclasses: "true" allowUndeclaredRTE: "true"	2	Warning
JavadocType	0	Warning
JavadocVariable	0	Warning
JavadocStyle checkEmptyJavadoc: "true"	0	Warning
ConstantName	0	Warning
LocalFinalVariableName	0	Warning
LocalVariableName	0	Warning
MemberName	0	Warning
MethodName	0	Warning
PackageName	0	Warning
ParameterName	0	Warning
StaticVariableName	0	Warning
TypeName	0	Warning
AvoidStarImport	0	Warning
IllegalImport	0	Warning
RedundantImport	0	Warning
UnusedImports	6	Warning
FileLength max: "1000"	0	Warning
LineLength max: "120"	31	Warning
MethodLength max: "50"	10	Warning
ParameterNumber max: "5"	0	Warning
EmptyForIteratorPad	0	Warning
MethodParamPad	0	Warning
TabCharacter	0	Warning
ModifierOrder	0	Warning
AvoidNestedBlocks	0	Warning
EmptyBlock	0	Warning
LeftCurly	0	Warning
NeedBraces	0	Warning
RightCurly	0	Warning
AvoidInlineConditionals	0	Warning
DoubleCheckedLocking	0	Warning
EmptyStatement	0	Warning
EqualsHashCode	0	Warning
HiddenField	1	Warning
IllegalInstantiation	0	Warning
InnerAssignment	0	Warning
MissingSwitchDefault	0	Warning
RedundantThrows	0	Warning
SimplifyBooleanExpression	0	Warning
SimplifyBooleanReturn	0	Warning
FinalClass	0	Warning
HideUtilityClassConstructor	1	Warning
InterfaceIsType	0	Warning
VisibilityModifier	0	Warning
ArrayTypeStyle	0	Warning
UpperEll	0	Warning
AbstractClassName format: "^Abstract.*$|^Base.*$"	0	Warning
AnonInnerLength	0	Warning
EmptyForInitializerPad	0	Warning
CovariantEquals	0	Warning
DefaultComesLast	0	Warning
DeclarationOrder	0	Warning
ExplicitInitialization	0	Warning
FallThrough	0	Warning
IllegalCatch	5	Warning
IllegalThrows	0	Warning
JUnitTestCase	0	Warning
MultipleVariableDeclarations	0	Warning
PackageDeclaration	0	Warning
ParameterAssignment	0	Warning
ReturnCount max: "4"	0	Warning
StringLiteralEquality	0	Warning
SuperFinalize	0	Warning
ArrayTrailingComma	0	Warning
UnnecessaryParentheses	0	Warning
MutableException	0	Warning
ThrowsCount max: "3"	0	Warning
CyclomaticComplexity	8	Warning
TrailingComment	0	Warning
PackageHtml fileExtensions: "html"	0	Warning

Details

edu/internet2/middleware/shibboleth/idp/Version.java

Violation	Message	Line
	Utility classes should not have a public or default constructor.	20

edu/internet2/middleware/shibboleth/idp/authn/AuthenticationEngine.java

Violation	Message	Line
	Unused import - java.util.List.	28
	Line is longer than 120 characters.	155
	Cyclomatic Complexity is 12 (max allowed is 10).	347
	Method length is 54 lines (max allowed is 50).	347
	Line is longer than 120 characters.	764

edu/internet2/middleware/shibboleth/idp/authn/Saml2LoginContext.java

Violation	Message	Line
	Cyclomatic Complexity is 13 (max allowed is 10).	125

edu/internet2/middleware/shibboleth/idp/authn/provider/IPAddressLoginHandler.java

Violation	Message	Line
	'defaultDeny' hides a field.	73
	Missing a Javadoc comment.	128
	Missing a Javadoc comment.	138

edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginHandler.java

Violation	Message	Line
	Line is longer than 120 characters.	33

edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginServlet.java

Violation	Message	Line
	Catching 'Throwable' is not allowed.	191

edu/internet2/middleware/shibboleth/idp/config/profile/ProfileHandlerNamespaceHandler.java

Violation	Message	Line
	Line is longer than 120 characters.	28
	Line is longer than 120 characters.	29
	Line is longer than 120 characters.	31
	Line is longer than 120 characters.	32

edu/internet2/middleware/shibboleth/idp/config/profile/SAMLMetadataHandlerBeanDefinitionParser.java

Violation	Message	Line
	Line is longer than 120 characters.	26
	Line is longer than 120 characters.	30

edu/internet2/middleware/shibboleth/idp/config/profile/StatusHandlerBeanDefinitionParser.java

Violation	Message	Line
	Line is longer than 120 characters.	23

edu/internet2/middleware/shibboleth/idp/config/profile/authn/PreviousSessionLoginHandlerBeanDefinitionParser.java

Violation	Message	Line
	Line is longer than 120 characters.	54

edu/internet2/middleware/shibboleth/idp/profile/AbstractSAMLProfileHandler.java

Violation	Message	Line
	Cyclomatic Complexity is 12 (max allowed is 10).	496
	Method length is 55 lines (max allowed is 50).	496

edu/internet2/middleware/shibboleth/idp/profile/IdPProfileHandlerManager.java

Violation	Message	Line
	Catching 'Exception' is not allowed.	130
	Line is longer than 120 characters.	160

edu/internet2/middleware/shibboleth/idp/profile/SAMLMetadataProfileHandler.java

Violation	Message	Line
	Catching 'Exception' is not allowed.	65
	Catching 'Exception' is not allowed.	90

edu/internet2/middleware/shibboleth/idp/profile/saml1/AbstractSAML1ProfileHandler.java

Violation	Message	Line
	Line is longer than 120 characters.	285
	Cyclomatic Complexity is 14 (max allowed is 10).	577
	Method length is 75 lines (max allowed is 50).	577
	Cyclomatic Complexity is 11 (max allowed is 10).	703

edu/internet2/middleware/shibboleth/idp/profile/saml1/ArtifactResolution.java

Violation	Message	Line
	Line is longer than 120 characters.	200

edu/internet2/middleware/shibboleth/idp/profile/saml1/AttributeQueryProfileHandler.java

Violation	Message	Line
	Line is longer than 120 characters.	217

edu/internet2/middleware/shibboleth/idp/profile/saml1/BaseSAML1ProfileRequestContext.java

Violation	Message	Line
	Line is longer than 120 characters.	19

edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSODecoder.java

Violation	Message	Line
	Unused import - org.opensaml.common.SAMLObject.	21

edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSOProfileHandler.java

Violation	Message	Line
	Line is longer than 120 characters.	336
	Line is longer than 120 characters.	351

edu/internet2/middleware/shibboleth/idp/profile/saml2/AbstractSAML2ProfileHandler.java

Violation	Message	Line
	Method length is 52 lines (max allowed is 50).	249
	Line is longer than 120 characters.	268
	Line is longer than 120 characters.	269
	Line is longer than 120 characters.	348
	Cyclomatic Complexity is 14 (max allowed is 10).	509
	Method length is 74 lines (max allowed is 50).	509
	Cyclomatic Complexity is 12 (max allowed is 10).	629
	Method length is 53 lines (max allowed is 50).	629
	Line is longer than 120 characters.	654
	Line is longer than 120 characters.	655
	Cyclomatic Complexity is 18 (max allowed is 10).	732
	Method length is 76 lines (max allowed is 50).	732
	Line is longer than 120 characters.	744

edu/internet2/middleware/shibboleth/idp/profile/saml2/ArtifactResolution.java

Violation	Message	Line
	Method length is 54 lines (max allowed is 50).	89
	Line is longer than 120 characters.	225

edu/internet2/middleware/shibboleth/idp/profile/saml2/AttributeQueryProfileHandler.java

Violation	Message	Line
	Method length is 55 lines (max allowed is 50).	73
	Line is longer than 120 characters.	219

edu/internet2/middleware/shibboleth/idp/profile/saml2/BaseSAML2ProfileRequestContext.java

Violation	Message	Line
	Line is longer than 120 characters.	34

edu/internet2/middleware/shibboleth/idp/profile/saml2/SSOProfileHandler.java

Violation	Message	Line
	Unused import - javax.xml.parsers.DocumentBuilder.	26
	Unused import - javax.xml.parsers.DocumentBuilderFactory.	27
	Unused import - org.xml.sax.InputSource.	66
	Unused import - edu.internet2.middleware.shibboleth.idp.profile.saml1.ShibbolethSSOProfileHandler.ShibbolethSSORequestContext.	78
	Method length is 61 lines (max allowed is 50).	214
	Line is longer than 120 characters.	239
	Line is longer than 120 characters.	245
	Line is longer than 120 characters.	399
	Line is longer than 120 characters.	523
	Catching 'Exception' is not allowed.	565