Checkstyle Results

The following document contains the results of Checkstyle.

Summary

FilesInfos InfosWarnings WarningsErrors Errors
710960

Files

FilesI InfosW WarningsE Errors
edu/internet2/middleware/shibboleth/idp/StatusServlet.java080
edu/internet2/middleware/shibboleth/idp/Version.java010
edu/internet2/middleware/shibboleth/idp/authn/AuthenticationEngine.java080
edu/internet2/middleware/shibboleth/idp/authn/Saml2LoginContext.java010
edu/internet2/middleware/shibboleth/idp/authn/provider/IPAddressLoginHandler.java020
edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginHandler.java010
edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginServlet.java010
edu/internet2/middleware/shibboleth/idp/config/profile/ProfileHandlerNamespaceHandler.java040
edu/internet2/middleware/shibboleth/idp/config/profile/SAMLMetadataHandlerBeanDefinitionParser.java020
edu/internet2/middleware/shibboleth/idp/config/profile/StatusHandlerBeanDefinitionParser.java010
edu/internet2/middleware/shibboleth/idp/config/profile/authn/IPAddressLoginHandlerFactoryBean.java040
edu/internet2/middleware/shibboleth/idp/config/profile/authn/PreviousSessionLoginHandlerBeanDefinitionParser.java010
edu/internet2/middleware/shibboleth/idp/profile/AbstractSAMLProfileHandler.java010
edu/internet2/middleware/shibboleth/idp/profile/IdPProfileHandlerManager.java020
edu/internet2/middleware/shibboleth/idp/profile/SAMLMetadataProfileHandler.java020
edu/internet2/middleware/shibboleth/idp/profile/saml1/AbstractSAML1ProfileHandler.java090
edu/internet2/middleware/shibboleth/idp/profile/saml1/ArtifactResolution.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/AttributeQueryProfileHandler.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/BaseSAML1ProfileRequestContext.java010
edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSOProfileHandler.java030
edu/internet2/middleware/shibboleth/idp/profile/saml2/AbstractSAML2ProfileHandler.java0120
edu/internet2/middleware/shibboleth/idp/profile/saml2/ArtifactResolution.java030
edu/internet2/middleware/shibboleth/idp/profile/saml2/AttributeQueryProfileHandler.java020
edu/internet2/middleware/shibboleth/idp/profile/saml2/BaseSAML2ProfileRequestContext.java010
edu/internet2/middleware/shibboleth/idp/profile/saml2/SSOProfileHandler.java090
edu/internet2/middleware/shibboleth/idp/util/HttpServletHelper.java0120
edu/internet2/middleware/shibboleth/idp/util/IPRange.java030

Rules

RulesViolationsSeverity
JavadocMethod
  • allowThrowsTagsForSubclasses: "true"
  • allowUndeclaredRTE: "true"
2Warnings Warning
JavadocType0Warnings Warning
JavadocVariable4Warnings Warning
JavadocStyle
  • checkEmptyJavadoc: "true"
6Warnings Warning
ConstantName1Warnings Warning
LocalFinalVariableName0Warnings Warning
LocalVariableName0Warnings Warning
MemberName1Warnings Warning
MethodName0Warnings Warning
PackageName0Warnings Warning
ParameterName0Warnings Warning
StaticVariableName0Warnings Warning
TypeName0Warnings Warning
AvoidStarImport0Warnings Warning
IllegalImport0Warnings Warning
RedundantImport0Warnings Warning
UnusedImports1Warnings Warning
FileLength
  • max: "1000"
1Warnings Warning
LineLength
  • max: "120"
48Warnings Warning
MethodLength
  • max: "50"
9Warnings Warning
ParameterNumber
  • max: "5"
0Warnings Warning
EmptyForIteratorPad0Warnings Warning
MethodParamPad0Warnings Warning
TabCharacter0Warnings Warning
ModifierOrder0Warnings Warning
AvoidNestedBlocks0Warnings Warning
EmptyBlock2Warnings Warning
LeftCurly0Warnings Warning
NeedBraces0Warnings Warning
RightCurly0Warnings Warning
AvoidInlineConditionals2Warnings Warning
DoubleCheckedLocking0Warnings Warning
EmptyStatement0Warnings Warning
EqualsHashCode0Warnings Warning
HiddenField1Warnings Warning
IllegalInstantiation0Warnings Warning
InnerAssignment0Warnings Warning
MissingSwitchDefault0Warnings Warning
RedundantThrows0Warnings Warning
SimplifyBooleanExpression0Warnings Warning
SimplifyBooleanReturn0Warnings Warning
FinalClass0Warnings Warning
HideUtilityClassConstructor2Warnings Warning
InterfaceIsType0Warnings Warning
VisibilityModifier0Warnings Warning
ArrayTypeStyle0Warnings Warning
UpperEll0Warnings Warning
AbstractClassName
  • format: "^Abstract.*$|^Base.*$"
0Warnings Warning
AnonInnerLength0Warnings Warning
EmptyForInitializerPad0Warnings Warning
CovariantEquals0Warnings Warning
DefaultComesLast0Warnings Warning
DeclarationOrder0Warnings Warning
ExplicitInitialization0Warnings Warning
FallThrough0Warnings Warning
IllegalCatch6Warnings Warning
IllegalThrows0Warnings Warning
JUnitTestCase0Warnings Warning
MultipleVariableDeclarations0Warnings Warning
PackageDeclaration0Warnings Warning
ParameterAssignment0Warnings Warning
ReturnCount
  • max: "4"
0Warnings Warning
StringLiteralEquality2Warnings Warning
SuperFinalize0Warnings Warning
ArrayTrailingComma3Warnings Warning
UnnecessaryParentheses0Warnings Warning
MutableException0Warnings Warning
ThrowsCount
  • max: "3"
0Warnings Warning
CyclomaticComplexity5Warnings Warning
TrailingComment0Warnings Warning
PackageHtml
  • fileExtensions: "html"
0Warnings Warning

Details

edu/internet2/middleware/shibboleth/idp/StatusServlet.java

ViolationMessageLine
WarningsMissing a Javadoc comment.55
WarningsName 'IP_PARAM_NAME' must match pattern '^[a-z][a-zA-Z0-9]*$'.55
WarningsMissing a Javadoc comment.57
WarningsMissing a Javadoc comment.59
WarningsLine is longer than 120 characters.93
WarningsExpected @throws tag for 'ServletException'.118
WarningsCatching 'Throwable' is not allowed.223
WarningsMust have at least one statement.223

edu/internet2/middleware/shibboleth/idp/Version.java

ViolationMessageLine
WarningsUtility classes should not have a public or default constructor.20

edu/internet2/middleware/shibboleth/idp/authn/AuthenticationEngine.java

ViolationMessageLine
WarningsMissing a Javadoc comment.95
WarningsMethod length is 59 lines (max allowed is 50).226
WarningsCyclomatic Complexity is 12 (max allowed is 10).297
WarningsMethod length is 54 lines (max allowed is 50).297
WarningsLine is longer than 120 characters.457
WarningsLine is longer than 120 characters.708
WarningsLiteral Strings should be compared using equals(), not '=='.710
WarningsAvoid inline conditionals.710

edu/internet2/middleware/shibboleth/idp/authn/Saml2LoginContext.java

ViolationMessageLine
WarningsCyclomatic Complexity is 13 (max allowed is 10).125

edu/internet2/middleware/shibboleth/idp/authn/provider/IPAddressLoginHandler.java

ViolationMessageLine
WarningsMissing a Javadoc comment.56
Warnings'ipInRangeIsAuthenticated' hides a field.56

edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.33

edu/internet2/middleware/shibboleth/idp/authn/provider/UsernamePasswordLoginServlet.java

ViolationMessageLine
WarningsCatching 'Throwable' is not allowed.186

edu/internet2/middleware/shibboleth/idp/config/profile/ProfileHandlerNamespaceHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.28
WarningsLine is longer than 120 characters.29
WarningsLine is longer than 120 characters.31
WarningsLine is longer than 120 characters.32

edu/internet2/middleware/shibboleth/idp/config/profile/SAMLMetadataHandlerBeanDefinitionParser.java

ViolationMessageLine
WarningsLine is longer than 120 characters.26
WarningsLine is longer than 120 characters.30

edu/internet2/middleware/shibboleth/idp/config/profile/StatusHandlerBeanDefinitionParser.java

ViolationMessageLine
WarningsLine is longer than 120 characters.23

edu/internet2/middleware/shibboleth/idp/config/profile/authn/IPAddressLoginHandlerFactoryBean.java

ViolationMessageLine
WarningsJavadoc has empty description section.43
WarningsJavadoc has empty description section.50
WarningsJavadoc has empty description section.57
WarningsLine is longer than 120 characters.66

edu/internet2/middleware/shibboleth/idp/config/profile/authn/PreviousSessionLoginHandlerBeanDefinitionParser.java

ViolationMessageLine
WarningsLine is longer than 120 characters.54

edu/internet2/middleware/shibboleth/idp/profile/AbstractSAMLProfileHandler.java

ViolationMessageLine
WarningsUnused import - org.opensaml.common.binding.SAMLMessageContext.26

edu/internet2/middleware/shibboleth/idp/profile/IdPProfileHandlerManager.java

ViolationMessageLine
WarningsCatching 'Exception' is not allowed.130
WarningsLine is longer than 120 characters.160

edu/internet2/middleware/shibboleth/idp/profile/SAMLMetadataProfileHandler.java

ViolationMessageLine
WarningsCatching 'Exception' is not allowed.65
WarningsCatching 'Exception' is not allowed.90

edu/internet2/middleware/shibboleth/idp/profile/saml1/AbstractSAML1ProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.285
WarningsCyclomatic Complexity is 14 (max allowed is 10).361
WarningsMethod length is 63 lines (max allowed is 50).361
WarningsLine is longer than 120 characters.394
WarningsLine is longer than 120 characters.405
WarningsLine is longer than 120 characters.413
WarningsArray should contain trailing comma.415
WarningsMethod length is 57 lines (max allowed is 50).600
WarningsCyclomatic Complexity is 11 (max allowed is 10).745

edu/internet2/middleware/shibboleth/idp/profile/saml1/ArtifactResolution.java

ViolationMessageLine
WarningsLine is longer than 120 characters.203

edu/internet2/middleware/shibboleth/idp/profile/saml1/AttributeQueryProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.217

edu/internet2/middleware/shibboleth/idp/profile/saml1/BaseSAML1ProfileRequestContext.java

ViolationMessageLine
WarningsLine is longer than 120 characters.19

edu/internet2/middleware/shibboleth/idp/profile/saml1/ShibbolethSSOProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.244
WarningsLine is longer than 120 characters.344
WarningsLine is longer than 120 characters.359

edu/internet2/middleware/shibboleth/idp/profile/saml2/AbstractSAML2ProfileHandler.java

ViolationMessageLine
WarningsFile length is 1,090 lines (max allowed is 1,000).1
WarningsLine is longer than 120 characters.311
WarningsLine is longer than 120 characters.312
WarningsLine is longer than 120 characters.390
WarningsMethod length is 57 lines (max allowed is 50).552
WarningsLine is longer than 120 characters.748
WarningsCyclomatic Complexity is 22 (max allowed is 10).828
WarningsMethod length is 97 lines (max allowed is 50).828
WarningsLine is longer than 120 characters.840
WarningsLine is longer than 120 characters.904
WarningsArray should contain trailing comma.906
WarningsArray should contain trailing comma.916

edu/internet2/middleware/shibboleth/idp/profile/saml2/ArtifactResolution.java

ViolationMessageLine
WarningsMethod length is 63 lines (max allowed is 50).91
WarningsLine is longer than 120 characters.132
WarningsLine is longer than 120 characters.240

edu/internet2/middleware/shibboleth/idp/profile/saml2/AttributeQueryProfileHandler.java

ViolationMessageLine
WarningsMethod length is 56 lines (max allowed is 50).74
WarningsLine is longer than 120 characters.225

edu/internet2/middleware/shibboleth/idp/profile/saml2/BaseSAML2ProfileRequestContext.java

ViolationMessageLine
WarningsLine is longer than 120 characters.34

edu/internet2/middleware/shibboleth/idp/profile/saml2/SSOProfileHandler.java

ViolationMessageLine
WarningsLine is longer than 120 characters.172
WarningsMethod length is 60 lines (max allowed is 50).208
WarningsLine is longer than 120 characters.232
WarningsLine is longer than 120 characters.238
WarningsLine is longer than 120 characters.397
WarningsLine is longer than 120 characters.521
WarningsLine is longer than 120 characters.530
WarningsLine is longer than 120 characters.531
WarningsCatching 'Exception' is not allowed.563

edu/internet2/middleware/shibboleth/idp/util/HttpServletHelper.java

ViolationMessageLine
WarningsUtility classes should not have a public or default constructor.46
WarningsLine is longer than 120 characters.54
WarningsLine is longer than 120 characters.66
WarningsLine is longer than 120 characters.75
WarningsLine is longer than 120 characters.78
WarningsLine is longer than 120 characters.84
WarningsLine is longer than 120 characters.99
WarningsName 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.115
WarningsLiteral Strings should be compared using equals(), not '=='.168
WarningsAvoid inline conditionals.168
WarningsLine is longer than 120 characters.386
WarningsMust have at least one statement.389

edu/internet2/middleware/shibboleth/idp/util/IPRange.java

ViolationMessageLine
WarningsFirst sentence should end with a period.28
WarningsFirst sentence should end with a period.37
WarningsFirst sentence should end with a period.47