Checkstyle Results

The following document contains the results of Checkstyle.

Summary

FilesInfos InfosWarnings WarningsErrors Errors
38101070

Files

FilesInfosWarningsErrors
org/opensaml/util/resource/ChainingResourceFilter.java010
org/opensaml/util/resource/FileBackedHttpResource.java020
org/opensaml/util/resource/PropertyReplacementResourceFilter.java010
org/opensaml/util/resource/ResourceChangeWatcher.java010
org/opensaml/ws/Version.java010
org/opensaml/ws/message/decoder/BaseMessageDecoder.java030
org/opensaml/ws/message/handler/Handler.java020
org/opensaml/ws/message/handler/HandlerChainAware.java030
org/opensaml/ws/security/provider/CertificateNameOptions.java010
org/opensaml/ws/security/provider/ClientCertAuthRule.java020
org/opensaml/ws/soap/client/SOAPClient.java010
org/opensaml/ws/soap/client/SOAPFaultException.java010
org/opensaml/ws/soap/client/http/TLSProtocolSocketFactory.java010
org/opensaml/ws/soap/soap11/Body.java010
org/opensaml/ws/soap/soap11/Detail.java010
org/opensaml/ws/soap/soap11/FaultActor.java010
org/opensaml/ws/soap/soap11/FaultCode.java010
org/opensaml/ws/soap/soap11/FaultString.java010
org/opensaml/ws/soap/soap11/Header.java010
org/opensaml/ws/soap/soap11/decoder/SOAP11Decoder.java010
org/opensaml/ws/soap/soap11/impl/FaultStringBuilder.java010
org/opensaml/ws/soap/util/SOAPConstants.java010
org/opensaml/ws/soap/util/SOAPHelper.java030
org/opensaml/ws/wsaddressing/Action.java010
org/opensaml/ws/wsaddressing/Address.java010
org/opensaml/ws/wsaddressing/AttributedQName.java010
org/opensaml/ws/wsaddressing/AttributedURI.java010
org/opensaml/ws/wsaddressing/EndpointReference.java010
org/opensaml/ws/wsaddressing/EndpointReferenceType.java010
org/opensaml/ws/wsaddressing/FaultTo.java010
org/opensaml/ws/wsaddressing/From.java010
org/opensaml/ws/wsaddressing/MessageID.java010
org/opensaml/ws/wsaddressing/Metadata.java010
org/opensaml/ws/wsaddressing/ProblemHeaderQName.java010
org/opensaml/ws/wsaddressing/ProblemIRI.java010
org/opensaml/ws/wsaddressing/ReferenceParameters.java020
org/opensaml/ws/wsaddressing/ReplyTo.java010
org/opensaml/ws/wsaddressing/RetryAfter.java010
org/opensaml/ws/wsaddressing/SoapAction.java010
org/opensaml/ws/wsaddressing/To.java010
org/opensaml/ws/wsaddressing/WSAddressingConstants.java010
org/opensaml/ws/wsaddressing/impl/ActionMarshaller.java010
org/opensaml/ws/wsaddressing/impl/ActionUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/AddressMarshaller.java010
org/opensaml/ws/wsaddressing/impl/AddressUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/EndpointReferenceMarshaller.java010
org/opensaml/ws/wsaddressing/impl/EndpointReferenceUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/FaultToMarshaller.java010
org/opensaml/ws/wsaddressing/impl/FaultToUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/FromMarshaller.java010
org/opensaml/ws/wsaddressing/impl/FromUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/MessageIDMarshaller.java010
org/opensaml/ws/wsaddressing/impl/MessageIDUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/ProblemHeaderQNameMarshaller.java010
org/opensaml/ws/wsaddressing/impl/ProblemHeaderQNameUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/ProblemIRIMarshaller.java010
org/opensaml/ws/wsaddressing/impl/ProblemIRIUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/ReplyToMarshaller.java010
org/opensaml/ws/wsaddressing/impl/ReplyToUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/RetryAfterMarshaller.java010
org/opensaml/ws/wsaddressing/impl/RetryAfterUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/SoapActionMarshaller.java010
org/opensaml/ws/wsaddressing/impl/SoapActionUnmarshaller.java010
org/opensaml/ws/wsaddressing/impl/ToMarshaller.java010
org/opensaml/ws/wsaddressing/impl/ToUnmarshaller.java010
org/opensaml/ws/wsaddressing/util/WSAddressingHelper.java010
org/opensaml/ws/wsfed/WSFedConstants.java010
org/opensaml/ws/wssecurity/AttributedString.java010
org/opensaml/ws/wssecurity/AttributedURI.java010
org/opensaml/ws/wssecurity/Created.java010
org/opensaml/ws/wssecurity/Expires.java010
org/opensaml/ws/wssecurity/Iteration.java010
org/opensaml/ws/wssecurity/Nonce.java010
org/opensaml/ws/wssecurity/Salt.java010
org/opensaml/ws/wssecurity/Security.java010
org/opensaml/ws/wssecurity/SecurityTokenReference.java010
org/opensaml/ws/wssecurity/TransformationParameters.java020
org/opensaml/ws/wssecurity/Username.java010
org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObject.java020
org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObjectBuilder.java030
org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObjectMarshaller.java030
org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObjectUnmarshaller.java040
org/opensaml/ws/wssecurity/impl/AttributedStringMarshaller.java010
org/opensaml/ws/wssecurity/impl/CreatedBuilder.java020
org/opensaml/ws/wssecurity/impl/ExpiresBuilder.java030

Rules

RulesViolationsSeverity
JavadocMethod
  • allowThrowsTagsForSubclasses: "true"
  • allowUndeclaredRTE: "true"
14Warnings Warning
JavadocType1Warnings Warning
JavadocVariable0Warnings Warning
JavadocStyle
  • checkEmptyJavadoc: "true"
3Warnings Warning
ConstantName0Warnings Warning
LocalFinalVariableName0Warnings Warning
LocalVariableName0Warnings Warning
MemberName0Warnings Warning
MethodName0Warnings Warning
PackageName0Warnings Warning
ParameterName0Warnings Warning
StaticVariableName0Warnings Warning
TypeName0Warnings Warning
AvoidStarImport0Warnings Warning
IllegalImport0Warnings Warning
RedundantImport0Warnings Warning
UnusedImports33Warnings Warning
FileLength
  • max: "1000"
0Warnings Warning
LineLength
  • max: "120"
12Warnings Warning
MethodLength
  • max: "50"
1Warnings Warning
ParameterNumber
  • max: "5"
0Warnings Warning
EmptyForIteratorPad0Warnings Warning
MethodParamPad0Warnings Warning
TabCharacter0Warnings Warning
ModifierOrder0Warnings Warning
AvoidNestedBlocks0Warnings Warning
EmptyBlock1Warnings Warning
LeftCurly0Warnings Warning
NeedBraces0Warnings Warning
RightCurly0Warnings Warning
AvoidInlineConditionals0Warnings Warning
DoubleCheckedLocking0Warnings Warning
EmptyStatement0Warnings Warning
EqualsHashCode0Warnings Warning
HiddenField0Warnings Warning
IllegalInstantiation0Warnings Warning
InnerAssignment0Warnings Warning
MissingSwitchDefault0Warnings Warning
RedundantThrows1Warnings Warning
SimplifyBooleanExpression0Warnings Warning
SimplifyBooleanReturn0Warnings Warning
FinalClass1Warnings Warning
HideUtilityClassConstructor3Warnings Warning
InterfaceIsType33Warnings Warning
VisibilityModifier0Warnings Warning
ArrayTypeStyle0Warnings Warning
UpperEll0Warnings Warning
AbstractClassName
  • format: "^Abstract.*$|^Base.*$"
0Warnings Warning
AnonInnerLength0Warnings Warning
EmptyForInitializerPad0Warnings Warning
CovariantEquals0Warnings Warning
DefaultComesLast0Warnings Warning
DeclarationOrder0Warnings Warning
ExplicitInitialization0Warnings Warning
FallThrough0Warnings Warning
IllegalCatch1Warnings Warning
IllegalThrows0Warnings Warning
JUnitTestCase0Warnings Warning
MultipleVariableDeclarations0Warnings Warning
PackageDeclaration0Warnings Warning
ParameterAssignment1Warnings Warning
ReturnCount
  • max: "4"
0Warnings Warning
StringLiteralEquality0Warnings Warning
SuperFinalize0Warnings Warning
ArrayTrailingComma0Warnings Warning
UnnecessaryParentheses0Warnings Warning
MutableException1Warnings Warning
ThrowsCount
  • max: "3"
0Warnings Warning
CyclomaticComplexity1Warnings Warning
TrailingComment0Warnings Warning
PackageHtml
  • fileExtensions: "html"
0Warnings Warning

Details

org/opensaml/util/resource/ChainingResourceFilter.java

ViolationMessageLine
WarningsAssignment of parameter 'resource' is not allowed.44

org/opensaml/util/resource/FileBackedHttpResource.java

ViolationMessageLine
WarningsCatching 'Exception' is not allowed.133
WarningsLine is longer than 120 characters.176

org/opensaml/util/resource/PropertyReplacementResourceFilter.java

ViolationMessageLine
WarningsUnused import - java.io.InputStreamReader.24

org/opensaml/util/resource/ResourceChangeWatcher.java

ViolationMessageLine
WarningsLine is longer than 120 characters.172

org/opensaml/ws/Version.java

ViolationMessageLine
WarningsUtility classes should not have a public or default constructor.20

org/opensaml/ws/message/decoder/BaseMessageDecoder.java

ViolationMessageLine
WarningsLine is longer than 120 characters.114
WarningsLine is longer than 120 characters.117
WarningsLine is longer than 120 characters.190

org/opensaml/ws/message/handler/Handler.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.message.decoder.MessageDecoder.20
WarningsUnused import - org.opensaml.ws.message.encoder.MessageEncoder.21

org/opensaml/ws/message/handler/HandlerChainAware.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.message.MessageContext.19
WarningsUnused import - org.opensaml.ws.message.decoder.MessageDecoder.20
WarningsUnused import - org.opensaml.ws.message.encoder.MessageEncoder.21

org/opensaml/ws/security/provider/CertificateNameOptions.java

ViolationMessageLine
WarningsUnused import - javax.security.auth.x500.X500Principal.21

org/opensaml/ws/security/provider/ClientCertAuthRule.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.transport.InTransport.25
WarningsUnused import - org.opensaml.ws.transport.Transport.26

org/opensaml/ws/soap/client/SOAPClient.java

ViolationMessageLine
WarningsExpected @throws tag for 'SOAPException'.44

org/opensaml/ws/soap/client/SOAPFaultException.java

ViolationMessageLine
WarningsThe field 'soapFault' must be declared final.29

org/opensaml/ws/soap/client/http/TLSProtocolSocketFactory.java

ViolationMessageLine
WarningsRedundant throws: 'IllegalArgumentException' is unchecked exception.60

org/opensaml/ws/soap/soap11/Body.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.29

org/opensaml/ws/soap/soap11/Detail.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.29

org/opensaml/ws/soap/soap11/FaultActor.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/soap/soap11/FaultCode.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/soap/soap11/FaultString.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/soap/soap11/Header.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.29

org/opensaml/ws/soap/soap11/decoder/SOAP11Decoder.java

ViolationMessageLine
WarningsMust have at least one statement.99

org/opensaml/ws/soap/soap11/impl/FaultStringBuilder.java

ViolationMessageLine
WarningsLine is longer than 120 characters.26

org/opensaml/ws/soap/util/SOAPConstants.java

ViolationMessageLine
WarningsUtility classes should not have a public or default constructor.21

org/opensaml/ws/soap/util/SOAPHelper.java

ViolationMessageLine
WarningsLine is longer than 120 characters.269
WarningsCyclomatic Complexity is 17 (max allowed is 10).600
WarningsMethod length is 58 lines (max allowed is 50).600

org/opensaml/ws/wsaddressing/Action.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/wsaddressing/Address.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/wsaddressing/AttributedQName.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.31

org/opensaml/ws/wsaddressing/AttributedURI.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.31

org/opensaml/ws/wsaddressing/EndpointReference.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.31

org/opensaml/ws/wsaddressing/EndpointReferenceType.java

ViolationMessageLine
WarningsLine is longer than 120 characters.31

org/opensaml/ws/wsaddressing/FaultTo.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/From.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/MessageID.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/Metadata.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.30

org/opensaml/ws/wsaddressing/ProblemHeaderQName.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/ProblemIRI.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/ReferenceParameters.java

ViolationMessageLine
WarningsLine is longer than 120 characters.30
Warningsinterfaces should describe a type and hence have methods.30

org/opensaml/ws/wsaddressing/ReplyTo.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/RetryAfter.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wsaddressing/SoapAction.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.30

org/opensaml/ws/wsaddressing/To.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/wsaddressing/WSAddressingConstants.java

ViolationMessageLine
WarningsClass WSAddressingConstants should be declared as final.27

org/opensaml/ws/wsaddressing/impl/ActionMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.Action.20

org/opensaml/ws/wsaddressing/impl/ActionUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.Action.20

org/opensaml/ws/wsaddressing/impl/AddressMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.Address.19

org/opensaml/ws/wsaddressing/impl/AddressUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.Address.20

org/opensaml/ws/wsaddressing/impl/EndpointReferenceMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.EndpointReference.20

org/opensaml/ws/wsaddressing/impl/EndpointReferenceUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.EndpointReference.20

org/opensaml/ws/wsaddressing/impl/FaultToMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.FaultTo.20

org/opensaml/ws/wsaddressing/impl/FaultToUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.FaultTo.20

org/opensaml/ws/wsaddressing/impl/FromMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.From.20

org/opensaml/ws/wsaddressing/impl/FromUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.From.20

org/opensaml/ws/wsaddressing/impl/MessageIDMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.MessageID.20

org/opensaml/ws/wsaddressing/impl/MessageIDUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.MessageID.20

org/opensaml/ws/wsaddressing/impl/ProblemHeaderQNameMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.ProblemHeaderQName.20

org/opensaml/ws/wsaddressing/impl/ProblemHeaderQNameUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.MessageID.20

org/opensaml/ws/wsaddressing/impl/ProblemIRIMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.ProblemIRI.20

org/opensaml/ws/wsaddressing/impl/ProblemIRIUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.ProblemIRI.20

org/opensaml/ws/wsaddressing/impl/ReplyToMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.ReplyTo.20

org/opensaml/ws/wsaddressing/impl/ReplyToUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.ReplyTo.20

org/opensaml/ws/wsaddressing/impl/RetryAfterMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.RetryAfter.19

org/opensaml/ws/wsaddressing/impl/RetryAfterUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.RetryAfter.19

org/opensaml/ws/wsaddressing/impl/SoapActionMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.SoapAction.19

org/opensaml/ws/wsaddressing/impl/SoapActionUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.SoapAction.19

org/opensaml/ws/wsaddressing/impl/ToMarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.To.20

org/opensaml/ws/wsaddressing/impl/ToUnmarshaller.java

ViolationMessageLine
WarningsUnused import - org.opensaml.ws.wsaddressing.To.20

org/opensaml/ws/wsaddressing/util/WSAddressingHelper.java

ViolationMessageLine
WarningsLine is longer than 120 characters.51

org/opensaml/ws/wsfed/WSFedConstants.java

ViolationMessageLine
WarningsUtility classes should not have a public or default constructor.20

org/opensaml/ws/wssecurity/AttributedString.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/wssecurity/AttributedURI.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/wssecurity/Created.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.25

org/opensaml/ws/wssecurity/Expires.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.25

org/opensaml/ws/wssecurity/Iteration.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.31

org/opensaml/ws/wssecurity/Nonce.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.27

org/opensaml/ws/wssecurity/Salt.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.30

org/opensaml/ws/wssecurity/Security.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.31

org/opensaml/ws/wssecurity/SecurityTokenReference.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.32

org/opensaml/ws/wssecurity/TransformationParameters.java

ViolationMessageLine
WarningsLine is longer than 120 characters.29
Warningsinterfaces should describe a type and hence have methods.29

org/opensaml/ws/wssecurity/Username.java

ViolationMessageLine
Warningsinterfaces should describe a type and hence have methods.28

org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObject.java

ViolationMessageLine
WarningsFirst sentence should end with a period.26
WarningsMissing a Javadoc comment.48

org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObjectBuilder.java

ViolationMessageLine
WarningsFirst sentence should end with a period.24
WarningsType Javadoc comment is missing an @param <WSSecurityObjectType> tag.28
WarningsMissing a Javadoc comment.37

org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObjectMarshaller.java

ViolationMessageLine
WarningsInvalid use of the {@inheritDoc} tag.35
WarningsMissing a Javadoc comment.46
WarningsMissing a Javadoc comment.57

org/opensaml/ws/wssecurity/impl/AbstractWSSecurityObjectUnmarshaller.java

ViolationMessageLine
WarningsInvalid use of the {@inheritDoc} tag.42
WarningsMissing a Javadoc comment.52
WarningsMissing a Javadoc comment.64
WarningsMissing a Javadoc comment.75

org/opensaml/ws/wssecurity/impl/AttributedStringMarshaller.java

ViolationMessageLine
WarningsLine is longer than 120 characters.36

org/opensaml/ws/wssecurity/impl/CreatedBuilder.java

ViolationMessageLine
WarningsMissing a Javadoc comment.32
WarningsMissing a Javadoc comment.43

org/opensaml/ws/wssecurity/impl/ExpiresBuilder.java

ViolationMessageLine
WarningsFirst sentence should end with a period.21
WarningsMissing a Javadoc comment.32
WarningsMissing a Javadoc comment.43